shards icon indicating copy to clipboard operation
shards copied to clipboard
verified publisher icon crystal-lang

Add remove and add commands

Open navid-m opened this issue 7 months ago • 6 comments

As discussed, edits can be made to match exact requirements for checks.

navid-m avatar May 08 '25 01:05 navid-m

This pull request has been mentioned on Crystal Forum. There might be relevant details there:

https://forum.crystal-lang.org/t/i-wrote-a-cli-over-shards-that-adds-and-removes-shards-from-a-project-can-search-for-shards-visualize-dependency-trees-of-shards-and-more/8040/14

crysbot avatar May 09 '25 17:05 crysbot

@navid-m You push a PR, hence I review. Unsubscribe from the PR if you don't want notifications.

Anyway, there are edge cases to take care of, too. Probably needs to detect and fail with an explicit error:

  • add: what if the dependency is already declared?
  • add: what if the dependency is already declared as a development dependency (or the opposite)?
  • add: what if the dependency is declared but the source (and resolver) changed?
  • ...

ysbaddaden avatar May 13 '25 06:05 ysbaddaden

@navid-m You push a PR, hence I review. Unsubscribe from the PR if you don't want notifications.

Anyway, there are edge cases to take care of, too. Probably needs to detect and fail with an explicit error:

  • add: what if the dependency is already declared?
  • add: what if the dependency is already declared as a development dependency (or the opposite)?
  • add: what if the dependency is declared but the source (and resolver) changed?
  • ...

Good job not addressing a single fucking thing I said. Bye.

navid-m avatar May 13 '25 08:05 navid-m

@navid-m There's no need for this toxicity. If you had expressed your intentions in the initial PR comment then things could have been handled differently. Reviews will continue to be made as others contribute to the PR, so as Julien said, please unsubscribe if you don't want to be notified.

devnote-dev avatar May 13 '25 08:05 devnote-dev

@navid-m There's no need for this toxicity. If you had expressed your intentions in the initial PR comment then things could have been handled differently. Reviews will continue to be made as others contribute to the PR, so as Julien said, please unsubscribe if you don't want to be notified.

Fuck off.

navid-m avatar May 13 '25 18:05 navid-m

FWIW my intention was/is to take the PR from here. I just haven't pushed my iterations.

Meanwhile, it serves for discussing what is missing from POC to something we can ship.

Thanks everyone for the contributions and reviews meanwhile.

bcardiff avatar May 13 '25 21:05 bcardiff