distribution-scripts icon indicating copy to clipboard operation
distribution-scripts copied to clipboard
verified publisher icon crystal-lang

Use universal darwin build for previous crystal

Open miry opened this issue 2 years ago • 5 comments

For last few crystal releases there is only crystal-darwin-universal. It means, there is no need to separate on ARCH in Makefiles or folder names for darwin.

Update darwin/Makefile to use folder name without arch suffix.

Example usage:

make -C darwin CRYSTAL_VERSION=1.10.1 PREVIOUS_CRYSTAL_RELEASE_DARWIN_TARGZ=https://github.com/crystal-lang/crystal/releases/download/1.10.1/crystal-1.10.1-1-darwin-universal.tar.gz

my level of understanding the whole process: noob

miry avatar Nov 11 '23 21:11 miry

CI workflow run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13351/workflows/0e70450f-675a-4382-98c1-6ec959e61eea

straight-shoota avatar Nov 13 '23 14:11 straight-shoota

checking failed test

miry avatar Nov 13 '23 17:11 miry

Updated the code to use crystal-darwin-universal folder name and found a missing spot, where the folder was used.

miry avatar Nov 13 '23 18:11 miry

New CI run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13356/workflows/5a0c364e-6f0d-40b5-bd29-6095dfb66302

straight-shoota avatar Nov 13 '23 19:11 straight-shoota

New CI run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13882/workflows/ab68057e-075c-43b8-96a2-8e5b2db11597

straight-shoota avatar Jan 02 '24 11:01 straight-shoota