crystal icon indicating copy to clipboard operation
crystal copied to clipboard

add an "overrides" annotation

Open repomaa opened this issue 8 years ago • 36 comments

this will prevent you from doing something like

class Foo
  def foobar
    2
  end
end

class Bar < Foo
  def foobaz # whoops a typo
    3
  end
end

Bar.new.foobar #=> 2 - Whaat?

repomaa avatar Sep 29 '15 17:09 repomaa

@eyalsh99 thanks for the fix. I was wondering whether you did a git blame to try to decipher why we were quoting the type in the past? I agree it seems atypical, but there likely was some pseudo valid reason.

john-bodley avatar May 01 '24 17:05 john-bodley

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.39%. Comparing base (c975f97) to head (38033f2). Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28305      +/-   ##
==========================================
+ Coverage   60.48%   67.39%   +6.90%     
==========================================
  Files        1931     1933       +2     
  Lines       76236    76494     +258     
  Branches     8568     8568              
==========================================
+ Hits        46114    51553    +5439     
+ Misses      28017    22836    -5181     
  Partials     2105     2105              
Flag Coverage Δ
hive ?
mysql 77.52% <ø> (?)
postgres 77.65% <ø> (?)
presto ?
python 77.78% <ø> (+14.29%) :arrow_up:
sqlite 77.11% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 01 '24 17:05 codecov-commenter