crystal icon indicating copy to clipboard operation
crystal copied to clipboard

Add flags missing from termios

Open gergelyk opened this issue 1 year ago • 3 comments

Adding flags from c_cc characters section. Refer to https://sites.uclouvain.be/SystInfo/usr/include/bits/termios.h.html

gergelyk avatar Jun 01 '24 16:06 gergelyk

I agree. The only flag that I was missing in this project in fact was VTIME. It seems to be part of non-canonical mode, like VSTART, VSTOP, etc. What do you think? Should this PR include only VTIME?

gergelyk avatar Jun 10 '24 11:06 gergelyk

There's an ongoing discussion about the status of libc bindings in stdlib (#13504). The general idea is that we don't plan to support any bindings that are not used in stdlib itself. Unused bindings might be removed in the future (#11955). So I don't think it's a good idea to add more unused bindings at this point. This discussion is not finialized and might come to a different conclusion after all (though I doubt it).

If you need specific bindings for your project, it's probably best to define them in your own code.

straight-shoota avatar Jun 10 '24 12:06 straight-shoota

(I really should just restart my posix shard as a libc shard, with libvirt VMs to autogenerate the bindings for all supported targets)

ysbaddaden avatar Jun 10 '24 14:06 ysbaddaden

Closing. We shouldn't add new unused libc bindings to stdlib until there's a decision that we definitely want to maintain them.

Collecting such bindings in a shard seems like a good idea.

straight-shoota avatar Sep 06 '24 11:09 straight-shoota