crystal icon indicating copy to clipboard operation
crystal copied to clipboard

Published 20 hours ago • verified publisher icon crystal-lang

Move `Spec` context state into `Spec::CLI`

Open HertzDevil opened this issue 1 year ago • 2 comments

Follow-up to #14170. This includes the global variables inside Spec::RootContext.

HertzDevil avatar Jan 28 '24 00:01 HertzDevil

CLI is at the moment still :nodoc:, we could change it any time we want.

prints_summary? reflects the fact that formatters don't depend on a context. Any other refactoring would introduce an equally "unrelated" change.

HertzDevil avatar Jan 28 '24 13:01 HertzDevil

Not sure I understand what you mean. Wouldn't it be possible to apply the refactor from print_results to prints_summary? without the other changes? If it is, we should do it first, then move the other stuff around.

straight-shoota avatar Jan 29 '24 22:01 straight-shoota