crystal-lang
Zip64 writer+reader rebased
Replaces https://github.com/crystal-lang/crystal/pull/7236 Closes https://github.com/crystal-lang/crystal/issues/7103
The original PR was made by @julik
In this PR I did:
- [x] Rebased with
masterbranch. - [x] Updated code to make CI happy.
Thank you so much @mamantoha for picking this up. I was actually feeling very guilty for letting this rot for so long, but didn't have time (or energy) to pick it up again. Maybe you could take over my branch too if that's better (there were some comments there from what I see)
Hi @julik, this PR contains 2 commits from your branch rebased with the master branch + some minor changes in the third commit which fix specs. I even didn't change the specs for this :wink:. I had no plans to change your initial implementation. I was just curious if it actually worked. And yes, this working pretty well.
I will be delighted if you can pick up my implementation and drive it to completion, I won't have time in the coming months to do it.
@mamantoha This is really great! But it's also a lot of effort to review. Do you think there's a chance of splitting this into smaller pieces? I see there are a few new types added, but they seem to be used in the refactored code, so I don't see an easy way for that.
CRC32Writer is missing specs. It's a public API so it should be tested by itself (or really even if it was internal).
