crystal-mysql
crystal-mysql copied to clipboard
Added basic JSON column support
At a minimum we should be able to read/write to JSON columns via a String. This solves for that.
https://github.com/crystal-lang/crystal-mysql/issues/64 https://github.com/amberframework/granite/issues/193
Changed it to serialize/deserialize a JSON::Any
object
I didn't want it to get confused with the JSON class. But can change if you'd like On Fri, Aug 17, 2018 at 7:05 PM Julien Portalier [email protected] wrote:
@ysbaddaden commented on this pull request.
Looks good. Maybe just use MySQL::Type::JSON instead of MySQL::Type::Json but that's nitpicking.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/crystal-lang/crystal-mysql/pull/65#pullrequestreview-147403500, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXk7BQoAVvicYkAcGEBI9ZEfw7AHIHFks5uR0wcgaJpZM4V8-yb .
@bcardiff any input?
Brining branch up to speed and checking in.
Does this need more work?