libcrux icon indicating copy to clipboard operation
libcrux copied to clipboard

`[no_std]` compatibility for standalone crates

Open jschneider-bensch opened this issue 1 year ago • 2 comments

E.g. for libcrux-kem, or in general where possible.

jschneider-bensch avatar Jun 12 '24 08:06 jschneider-bensch

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Aug 23 '24 12:08 github-actions[bot]

@jschneider-bensch let's list the crates and what needs to get done.

franziskuskiefer avatar Aug 26 '24 19:08 franziskuskiefer

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Oct 30 '24 02:10 github-actions[bot]

Assigning to @keks as part of the first iteration of a pure Rust libcrux #648.

franziskuskiefer avatar Oct 31 '24 10:10 franziskuskiefer

I made most crates no_std in #697. Some didn't work, though:

  • sys/hacl: depends on std::os
  • psq: uses std::time::SystemTime
  • macros: is proc-macro, so shouldn't need to

The PSQ one might be solvable, but I think our chances for sys/hacl are not very good. But since we are already in the way to migrating to hacl-rs, that is temporary.

@franziskuskiefer if you don't have objections, I would close this as resolved.

keks avatar Nov 27 '24 09:11 keks

  • sys/hacl: depends on std::os

As you say, since this is for wrapping C code we don't care for the pure Rust version.

  • psq: uses std::time::SystemTime

Let's not put this in scope for the first pure Rust release and file a separate issue for time not being in core.

  • macros: is proc-macro, so shouldn't need to

Right, this is fine.

Let's file that psq issue and close this.

franziskuskiefer avatar Nov 27 '24 10:11 franziskuskiefer