libcrux icon indicating copy to clipboard operation
libcrux copied to clipboard

[SHA-3] Use constants for rates and delimiters

Open jschneider-bensch opened this issue 6 months ago • 3 comments

It would be nice to have constants for all the rates and delimiters. This would make it harder to use the wrong constant in some place and/or make it easier to spot.

Originally posted by @jschneider-bensch in https://github.com/cryspen/libcrux/pull/1013#discussion_r2163132938

jschneider-bensch avatar Jun 30 '25 05:06 jschneider-bensch

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Aug 30 '25 01:08 github-actions[bot]

@Parrot7483: This is a nice-to-have, but low priority item. If we did this now, would it mess with your proof efforts, or would it be an easy fix on your side? I don't want to create unnecessary friction.

jschneider-bensch avatar Sep 22 '25 06:09 jschneider-bensch

I do not think it is a problem.

parrot7483 avatar Sep 22 '25 08:09 parrot7483

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Nov 22 '25 01:11 github-actions[bot]

This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment.

github-actions[bot] avatar Nov 30 '25 01:11 github-actions[bot]