chrome-react-perf icon indicating copy to clipboard operation
chrome-react-perf copied to clipboard

Bundle react-addons-perf?

Open JamieMason opened this issue 8 years ago • 1 comments

Hey, thanks for creating this extension.

I wondered if, similar to how Immutable.js Object Formatter bundles immutable-devtools, do you think it could be worthwhile for chrome-react-perf to bundle react-addons-perf?

Thanks a lot,

Jamie

JamieMason avatar Apr 20 '16 13:04 JamieMason

Thanks for the advice.

It's better to keep react-addons-perf the same version as react. APIs may change between versions. Bundle react-addons-perf in the app is the simplest way to ensure that.

react-addons-perf can be stripped out in production with

if (NODE_ENV !== 'production') {
   require('expose?Perf!react-addons-perf');
}

I will look into that extension and the source of react-addons-perf, to see whether there is a way.

crysislinux avatar Apr 25 '16 10:04 crysislinux