chrome-react-perf icon indicating copy to clipboard operation
chrome-react-perf copied to clipboard

No output generated

Open jtadmor opened this issue 8 years ago • 8 comments

Hi,

This tool looks awesome, but I can't get it to work.

I'm using it by:

import Perf from 'react-addons-perf'
window.Perf = Perf

I start, make some changes, stop. All I see is:

screen shot 2016-04-12 at 4 53 20 pm

I am using this with react 15.0.1, Chrome 49.0.2623 if that helps.

jtadmor avatar Apr 12 '16 22:04 jtadmor

seems not compatible with v15 now. the extension uses a different version of react-addons-perf I am trying to fix it.

crysislinux avatar Apr 13 '16 00:04 crysislinux

It should work now.

Notice: printDOM is deprecated in React v15, and printOperations is suggested.

It still called dom in the extension, but it is operations in fact if React v15 is used.

Let me know if you meet problems :)

crysislinux avatar Apr 13 '16 15:04 crysislinux

I'm still seeing the same. Tried uninstalling and reinstalling the plugin and hard refresh browser, no luck.

jtadmor avatar Apr 13 '16 22:04 jtadmor

I cannot reproduce the problem. Could you send me a minimal sample of your code?

I tested with:

  • react 15.0.1
  • react-addons-perf 15.0.1
  • Chrome 49.0.2623
  • chrome-react-perf 1.10

image

One more thing. At least one component should rerender during the recording.

Please try to manually type Perf.start() Perf.stop() and Perf.printOperations in the console.

The extension should show the same thing as the console.

crysislinux avatar Apr 13 '16 23:04 crysislinux

This is manually doing it in the console:

screen shot 2016-04-13 at 5 54 09 pm

Clicking the same buttons while recording does not produce any output.

What code would you be wanting to see?

(Edit to add: Not trying to be a pain, dont feel the need to reply or anything, I may look through the code this weekend myself).

jtadmor avatar Apr 13 '16 23:04 jtadmor

Just to chip in with my experience, 15.0.0 didn't work for me. If I go back to 0.14.8 or forward to 15.0.1 the print outs started working again.

Thanks!

andyg303 avatar May 18 '16 10:05 andyg303

I meet the same question now, sometimes it works as the Landlord printed, sometimes it returns like

2016-11-21 2 33 52

but still no wasted print, I can not believe there is no wasted in the application.

[email protected] [email protected] React Perf 1.1.0 chrome 54.0.2840.98 (64-bit)

thanks.

FionaWong avatar Nov 21 '16 06:11 FionaWong

Hello, I have faced same issue - no wasted output. But this is the same from console and from extension. react

react-state avatar May 29 '17 11:05 react-state