chrome-react-perf icon indicating copy to clipboard operation
chrome-react-perf copied to clipboard

update docs to Webpack 2

Open brandly opened this issue 7 years ago • 2 comments

hey! thanks for this!!

webpack 2 is now stable. here are the changes that apply to these docs

i could send a PR, if you'd like. would you rather update to document just webpack 2, or add webpack 2 docs in addition to what's there already?

brandly avatar Apr 12 '17 18:04 brandly

Thanks. a PR is always welcomed. I tend to keep the doc for webpack 1 (of cause we need to make a title for each version) and prepend the webpack 2 version.

I haven't used React myself for a long time. I am not sure if this extension still works for React now.

I will file an issue to see if people still need this extension. If yes, I will keep developing this extension to make it better. Maybe you can make the PR at then. But again. I am also happy to see the PR if you'd like to send it now.

crysislinux avatar Apr 15 '17 02:04 crysislinux

I am not sure if this extension still works for React now.

i got it working! initially, i'd click "start" and it would give no feedback. adding these lines to my project appears to have worked:

if (process.env.NODE_ENV !== 'production') {
  window.Perf = require('react-addons-perf')
}

so i actually didn't go down the webpack route.

I will file an issue to see if people still need this extension.

i discovered this extension in this article by Twitter engineering! i haven't spent much time using it, but it's already been helpful. thanks again! 🌟

brandly avatar Apr 15 '17 15:04 brandly