Double-click on an Unlocked Vault

[MSevenR]

Double-click on an Unlocked Vault in the List to Reveal It

Double clicking an encrypted vault will allow you to unlock it. And then doing the same to an unlocked vault will automatically open it.

Summary by CodeRabbit

• New Features
  • Enhanced vault interaction by automatically revealing any unlocked vault in the UI.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai[bot]]

Walkthrough

The update in VaultListController.java enhances the functionality of the Cryptomator UI by integrating the VaultService. This service allows for the automatic revelation of unlocked vaults, improving user interaction by enabling a feature where a double-click on an unlocked vault in the list reveals it in the file explorer.

Changes

File Path	Change Summary
.../ui/mainwindow/VaultListController.java	Added VaultService integration and logic for revealing unlocked vaults upon selection.

Possibly related issues

• cryptomator/cryptomator#3390: This PR directly implements the feature requested in the issue, which is to reveal an unlocked vault by double-clicking on it in the vault list.
• cryptomator/cryptomator#3352: While this PR does not integrate unlocked vaults into the system file manager sidebar, it enhances access to unlocked vaults, which is a related enhancement in user accessibility of vaults.

🐇✨ A hop, a skip, a double-click, Reveal the secrets, smooth and quick. Vaults unlock with ease and flair, Thanks to the code from the rabbit's lair. 🌟🔓

---

Recent Review Details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0585262952e8a745fd42ad5a2f66460bc8596514 and d6ed88b5446e0d5eef9025677e12cad4c98accc5.

Files selected for processing (1)

• src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java (5 hunks)

Additional comments not posted (4)

src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java (4)

10-10: Import of org.cryptomator.ui.common.VaultService added.

This import is necessary for the new functionality to interact with vault-related services.

---

62-62: Addition of vaultService field.

This field is essential for handling vault operations, which is central to the new feature of unlocking/opening vaults via double-click.

---

Line range hint 84-94: Modification to the constructor to include VaultService.

Proper dependency injection of VaultService ensures that vault operations can be managed effectively within this controller.

---

126-128: New logic for handling double-click on unlocked vaults.

This enhancement improves user experience by allowing direct access to unlocked vaults with a double-click, utilizing the vaultService effectively.

[!WARNING]

Following problems were encountered

• Git: Failed to clone repository. Please contact CodeRabbit support.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MSevenR]

Never submitted to a project before so if I did anything wrong please let me know!

[mindmonk]

@MSevenR Thank you for contributing for Cryptomator! Your suggested change works flawlessly and can be used. However, I noticed that the description might be a bit misleading, as the feature to unlock an encrypted vault with a double click is already available and not included in this Pull Request.

[tobihagemann]

@mindmonk I've updated the description, since this shouldn't be a blocker, but thank you for pointing it out! If you've reviewed the code and agree with the changes, please submit an approval. Thank you!