android icon indicating copy to clipboard operation
android copied to clipboard

No unlock while rotating the screen

Open jivarson opened this issue 4 years ago • 5 comments

Description

When rotation is enabled, when trying to unlock a vault while the enter password or biometric auth dialog is present, rotate the screen, after a successful authentication, one is returned to the vault list with the vault still being locked

System Setup

Android 10, oneplus 7 Cryptomator 1.5.12 (though issue has been around for while)

Steps to Reproduce

  1. Enable autorotation
  2. Open Cryptomator in landscape mode
  3. Open a vault with biometric unlocking enabled.
  4. Select vault
  5. When biometric auth dialog is visible, rotate screen
  6. Enter credentials

Expected Behavior

User is presented with the unlocked vaults content

Actual Behavior

User is returned to Cryptomators main window, the vault in question is still locked

Reproducibility

Always

Additional Information

Issue is likely in the way Cryptomator for Android handles change of orientation while prompts or modals are open, they're not retained when the main window is realigned\redrawned

jivarson avatar Feb 22 '21 18:02 jivarson

I've no idea why my emulator is currently bottom up in landscape mode but I'm unable to reproduce your problem.

Peek 2021-02-22 20-58

SailReal avatar Feb 22 '21 20:02 SailReal

Your biometric prompt doesn't force portraitmode whereas mine does. Guess my OnePlus-device has a proprietery implementation or something.

I'm no dev, but it seems like when cryptomator enters the rotate\redraw event, it cancels out whatever prompts is going on so it cancels out.

Try to open just the passwordprompt for unlocking a vault in your emulator and rotate the device manually without entering anything in the prompt. For me the prompt dissappears then as well.

jivarson avatar Feb 23 '21 08:02 jivarson

Yes, that makes sense, thank you for reporting! I have generalized your issue somewhat to fit a larger bug cluster.

SailReal avatar Feb 23 '21 09:02 SailReal

I can confirm the issue on my OnePlus 8 Pro and as @jivarson already mentioned it seems to be related to the screen being rotated back to portrait mode after clicking the vault.

storm1ng avatar Apr 01 '21 10:04 storm1ng

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 26 '21 02:06 stale[bot]