scryptsy icon indicating copy to clipboard operation
scryptsy copied to clipboard

Improve Speed

Open jprichardson opened this issue 11 years ago • 7 comments

This algorithm is slower than it needs to be. Revert internal buffer usage to improve speed. Consider analysis from this article: http://blog.ircmaxell.com/2014/03/why-i-dont-recommend-scrypt.html

jprichardson avatar Jun 11 '14 23:06 jprichardson

Benchmark against: https://github.com/tonyg/js-scrypt

jprichardson avatar Jul 28 '14 11:07 jprichardson

Did a quick informal benchmark of scryptsy against js-scrypt using params of {N: 64, r: 4, p: 4} and dkLen or 64. js-scrypt is slightly faster (wall-clock), but its memory footprint is much much greater. There's a lot of room for optimizations for scryptsy.

jprichardson avatar Aug 23 '14 04:08 jprichardson

This is way faster (in node) now thanks to it using the pbkdf2 module, which can use the native sha256 in node 0.12 but falls back to a native JS module in node 0.10.

dcousens avatar Mar 20 '15 01:03 dcousens

Thanks for the lib, works decently in chrome, but it is unusable in FF 44.0.2, locks up the browser forcing a hard close

thinkloop avatar Mar 01 '16 10:03 thinkloop

@thinkloop as in, forever? That sounds like something to report to Mozilla...

dcousens avatar Mar 02 '16 01:03 dcousens

it is very strange, firefox 44 has almost same speed as chrome 49 for pbkdf2

fanatid avatar Mar 02 '16 05:03 fanatid

scrypt-async works well in all browsers, has zero locking for any chosen paramters, and I verified results against the node.js reference lib.

thinkloop avatar Mar 02 '16 09:03 thinkloop