Bugfix: Device does not have a matching signing key (Trezor)

[moneymanolis]

Fixes #1946 works with https://github.com/bitcoin-core/HWI/pull/644

Supplying an empty string as passphrase if the Trezor is passphrase enabled does not result in an error anymore.

[netlify[bot]]

✅ Deploy Preview for specter-desktop-docs canceled.

Name	Link
🔨 Latest commit	55a446dd11c01a2ea0700a7186dfe6590ca70688
🔍 Latest deploy log	https://app.netlify.com/sites/specter-desktop-docs/deploys/63e6a606c8100d00082b8ccd

[stepansnigirev]

Did you also check it still works:

• if the password is disabled in Trezor
• with other hardware wallets i.e. Ledger

[k9ert]

I was not able to verify, that this fixes the bug. So this should work without a new HWI-version, right? So as a workaround, download the https://trezor.io/trezor-suite and disable passphrase.

[moneymanolis]

I was not able to verify, that this fixes the bug. So this should work without a new HWI-version, right? So as a workaround, download the https://trezor.io/trezor-suite and disable passphrase.

Have you tested it with https://github.com/bitcoin-core/HWI/pull/644? You can directly disable the passphrase in Specter, too.

[moneymanolis]

I've tested with Model T and Model One, with and without passphrase enabled and with non-empty and empty passphrases. @k9ert can you try again, the PR mentioned above was merged by now, so you can just check with hwi master.

I double-checked again, the original issue was only with the Model One.

It seems like the changes in hwi would also just work with Specter master but the changes in this PR are still worthwhile with regards to more code clarity.

What is missing here is of course a change of the hwi version, but there has been no release lately. I will add the label waiting for upstream

[k9ert]

I think a double-check should not be needed. Next step would be to wait for the release. Hopefully we'll see that at the end of the month as Andrew said on the linked issue:

I plan on making a release at the beginning of the new year.

[k9ert]

Needs new hwi-version: https://github.com/bitcoin-core/HWI/releases/tag/2.2.0

[moneymanolis]

When building a new requirements.txt to include hwi 2.2.0 (from scratch) I get conflicting indirect dependencies:

Could not find a version that matches typing-extensions<4.0,>=3.7,>=3.7.4,>=4.2.0 (from hwi==2.2.0->-r requirements.in (line 11))
Tried: 3.6.2, 3.6.2, 3.6.2.1, 3.6.2.1, 3.6.5, 3.6.5, 3.6.6, 3.6.6, 3.7.2, 3.7.2, 3.7.4, 3.7.4, 3.7.4.1, 3.7.4.1, 3.7.4.2, 3.7.4.2, 3.7.4.3, 3.7.4.3, 3.10.0.0, 3.10.0.0, 3.10.0.1, 3.10.0.1, 3.10.0.2, 3.10.0.2, 4.0.0, 4.0.0, 4.0.1, 4.0.1, 4.1.0, 4.1.0, 4.1.1, 4.1.1, 4.2.0, 4.2.0, 4.3.0, 4.3.0, 4.4.0, 4.4.0
There are incompatible versions in the resolved dependencies:
  typing-extensions>=4.2.0 (from SQLAlchemy==2.0.3->Flask-SQLAlchemy==2.5.1->cryptoadvance.spectrum==0.3.1->-r requirements.in (line 37))
  typing-extensions>=3.7.4 (from bitbox02==6.1.1->hwi==2.2.0->-r requirements.in (line 11))
  typing-extensions<4.0,>=3.7 (from hwi==2.2.0->-r requirements.in (line 11))

Related: PR in hwi: https://github.com/bitcoin-core/HWI/pull/662 Issue in hwi: https://github.com/bitcoin-core/HWI/issues/572

[k9ert]

The dependency has been updated in hwi 2.2.1. Removing the waiting_for_upstream label.