cronos
cronos copied to clipboard
Problem: init/validate-genesis cmd include gravity module by default
Solution:
- Use different module managers according to --unsafe-experimental flag
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
- [ ] Have you read the CONTRIBUTING.md?
- [ ] Does your PR follow the C4 patch requirements?
- [ ] Have you rebased your work on top of the latest master?
- [ ] Have you checked your code compiles? (
make) - [ ] Have you included tests for any non-trivial functionality?
- [ ] Have you checked your code passes the unit tests? (
make test) - [ ] Have you checked your code formatting is correct? (
go fmt) - [ ] Have you checked your basic code style is fine? (
golangci-lint run) - [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (
go list -json -m all | nancy sleuth) - [ ] If your changes affect the client infrastructure, have you run the integration test?
- [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
- [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
- [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.
Thank you for your code, it's appreciated! :)
Codecov Report
Merging #639 (24bc6f7) into main (4be9702) will decrease coverage by
0.02%. The diff coverage is0.00%.
@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 32.93% 32.91% -0.03%
==========================================
Files 34 34
Lines 1603 1604 +1
==========================================
Hits 528 528
- Misses 1022 1023 +1
Partials 53 53
| Impacted Files | Coverage Δ | |
|---|---|---|
| app/genesis.go | 0.00% <0.00%> (ø) |
|
| app/state.go | 0.00% <0.00%> (ø) |
/runsim
Simulation tests started and triggered by /runsim.
Can check further progress here
lgtm, once the integration tests got fixed and the pystarport update to the crypto.com repo
/runsim
Simulation tests started and triggered by /runsim.
Can check further progress here