cronos icon indicating copy to clipboard operation
cronos copied to clipboard

feat(ibc)!: ibc-go v10 is not supported

Open JayT106 opened this issue 5 months ago • 4 comments

Integrated ibc-go v10.1.1 For the integration tests, using hermes relayer 1.13.1 instead of the customized ibc-go-relayer. So the relayer precompiled contract and the ica precompiled contract will not working with the hermes relayer.

ref #1731

PR Checklist:

  • [ ] Have you read the CONTRIBUTING.md?
  • [ ] Does your PR follow the C4 patch requirements?
  • [ ] Have you rebased your work on top of the latest master?
  • [ ] Have you checked your code compiles? (make)
  • [ ] Have you included tests for any non-trivial functionality?
  • [ ] Have you checked your code passes the unit tests? (make test)
  • [ ] Have you checked your code formatting is correct? (go fmt)
  • [ ] Have you checked your basic code style is fine? (golangci-lint run)
  • [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • [ ] If your changes affect the client infrastructure, have you run the integration test?
  • [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features
    • Support for IBC-Go v10 with updated protobufs and new IBC v2 protocol features.
    • Enhanced token handling in EVM contracts and events supporting denomination traces and multiple tokens per packet.
    • Added Cosmos token structures in Solidity and Go contract bindings.
  • Breaking Changes
    • Removal of IBC fee module (ICS29) and incentivized transfer features.
    • Channel upgrade functionality and related queries/transactions removed.
    • Major API changes in IBC transfer, channel, and client modules with renamed or removed protobuf messages and services.
    • Incentivized transfer and fee-related IBC tests are now skipped or disabled.
  • Improvements
    • Relayer event logs now use structured tokens for better traceability.
    • Dependency upgrades including Go 1.23 and updated Hermes relayer binary.
  • Bug Fixes
    • Fixed denom trace handling and event decoding in IBC transfers.
  • Chores
    • Updated build and Nix configurations.
    • Removed deprecated code, tests, and protobuf files.
  • Documentation
    • Updated changelog with state machine breaking changes due to IBC-Go v10 upgrade.

JayT106 avatar May 17 '25 02:05 JayT106