cronos icon indicating copy to clipboard operation
cronos copied to clipboard

Problem: rpc fails when basefee overflow int64

Open yihuang opened this issue 1 year ago • 2 comments

  • add integration test to reproduce

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • [ ] Have you read the CONTRIBUTING.md?
  • [ ] Does your PR follow the C4 patch requirements?
  • [ ] Have you rebased your work on top of the latest master?
  • [ ] Have you checked your code compiles? (make)
  • [ ] Have you included tests for any non-trivial functionality?
  • [ ] Have you checked your code passes the unit tests? (make test)
  • [ ] Have you checked your code formatting is correct? (go fmt)
  • [ ] Have you checked your basic code style is fine? (golangci-lint run)
  • [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • [ ] If your changes affect the client infrastructure, have you run the integration test?
  • [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where base fees could exceed system limits, potentially causing errors.
  • New Features
    • Introduced a new configuration setting for adjusting base fees and minimum gas prices in the cronos_777-1 network.
  • Tests
    • Added a test to verify JSON-RPC behavior when the base fee overflows int64.
  • Chores
    • Modified the setup functionality in the test_rollback file to use a different initial block height parameter.

yihuang avatar Mar 15 '24 02:03 yihuang