cronos icon indicating copy to clipboard operation
cronos copied to clipboard

Problem: missing ADR for precompiled

Open thomas-nguy opened this issue 2 years ago • 1 comments

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Draft for ADR-010

PR Checklist:

  • [ ] Have you read the CONTRIBUTING.md?
  • [ ] Does your PR follow the C4 patch requirements?
  • [ ] Have you rebased your work on top of the latest master?
  • [ ] Have you checked your code compiles? (make)
  • [ ] Have you included tests for any non-trivial functionality?
  • [ ] Have you checked your code passes the unit tests? (make test)
  • [ ] Have you checked your code formatting is correct? (go fmt)
  • [ ] Have you checked your basic code style is fine? (golangci-lint run)
  • [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • [ ] If your changes affect the client infrastructure, have you run the integration test?
  • [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

thomas-nguy avatar Oct 02 '23 09:10 thomas-nguy

Codecov Report

Merging #1191 (0e1f1d5) into main (79c911c) will decrease coverage by 20.24%. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1191       +/-   ##
===========================================
- Coverage   36.97%   16.73%   -20.24%     
===========================================
  Files         115       79       -36     
  Lines       10235     5766     -4469     
===========================================
- Hits         3784      965     -2819     
+ Misses       6078     4723     -1355     
+ Partials      373       78      -295     

see 54 files with indirect coverage changes

codecov[bot] avatar Oct 04 '23 05:10 codecov[bot]