chain-main icon indicating copy to clipboard operation
chain-main copied to clipboard

Problem: ibc-go v10.0 is not used

Open mmsqe opened this issue 10 months ago • 3 comments

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • [ ] Have you read the CONTRIBUTING.md?
  • [ ] Does your PR follow the C4 patch requirements?
  • [ ] Have you rebased your work on top of the latest master?
  • [ ] Have you checked your code compiles? (make)
  • [ ] Have you included tests for any non-trivial functionality?
  • [ ] Have you checked your code passes the unit tests? (make test)
  • [ ] Have you checked your code formatting is correct? (go fmt)
  • [ ] Have you checked your basic code style is fine? (golangci-lint run)
  • [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • [ ] If your changes affect the client infrastructure, have you run the integration test?
  • [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

mmsqe avatar Jan 15 '25 09:01 mmsqe

Codecov Report

Attention: Patch coverage is 80.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.92%. Comparing base (c2de0e1) to head (b38e568). Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
x/nft-transfer/client/cli/tx.go 33.33% 3 Missing and 3 partials :warning:
x/nft-transfer/ibc_module.go 66.66% 1 Missing and 3 partials :warning:
x/nft-transfer/keeper/relay.go 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
+ Coverage   31.75%   33.92%   +2.17%     
==========================================
  Files          93      101       +8     
  Lines       17026    17242     +216     
==========================================
+ Hits         5406     5849     +443     
+ Misses      10678    10445     -233     
- Partials      942      948       +6     
Flag Coverage Δ
integration_tests 23.83% <50.90%> (-0.08%) :arrow_down:
integration_tests_byzantine 10.81% <50.90%> (-0.15%) :arrow_down:
integration_tests_gov 11.05% <50.90%> (-0.15%) :arrow_down:
integration_tests_grpc 11.05% <50.90%> (-0.15%) :arrow_down:
integration_tests_ibc 26.23% <80.00%> (-0.29%) :arrow_down:
integration_tests_ledger 11.04% <50.90%> (-0.15%) :arrow_down:
integration_tests_slow 11.04% <50.90%> (-0.15%) :arrow_down:
integration_tests_solomachine 10.84% <50.90%> (-0.15%) :arrow_down:
integration_tests_upgrade 11.05% <50.90%> (-0.15%) :arrow_down:
unit_tests 11.48% <49.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jan 15 '25 09:01 codecov[bot]

Todo: Fix the hermes relayer

thomas-nguy avatar May 13 '25 06:05 thomas-nguy

Todo: Fix the hermes relayer

Can we have more context for the issue of the hermes relayer?

JayT106 avatar May 13 '25 13:05 JayT106