chain-jslib

chain-jslib copied to clipboard

There are multiple `Todos` for the issue.

cdc-Hitesh

cdc-Hitesh

We can add something like `.reset()` or `.clear()` on RawTransaction or SignableTransaction to let user rebuild txs from scratch.

cdc-Hitesh

Problem: Message related tests are temporarily disabled

1

https://github.com/crypto-org-chain/chain-jslib/pull/241/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R28

calvinaco

cdc-Hitesh

cdc-Hitesh

Old rawMsg : `{ typeUrl: COSMOS_MSG_TYPEURL.distribution.MsgSetWithdrawAddress, value: { delegatorAddress: this.delegatorAddress, validatorAddress: this.withdrawAddress, }, };` Instead of `validatorAddress` it should be `withdrawAddress`

cdc-Hitesh

**Describe the bug** MsgFundCommunityPool was encoding an incorrect Msg format, hence the signed hex was always losing `amount` information. Solution: Added a function call `.toCosmosCoins()` on the amount field in...

cdc-Hitesh

Solution: Add `fromCosmosJSON` method in respective message types.

cdc-Hitesh

Solution: Add `.fromCosmosJSON()` method in respective message classes.

cdc-Hitesh