thaler

thaler copied to clipboard

https://github.com/crypto-com/chain/pull/2235/checks?check_run_id=1134768446

tomtau

https://travis-ci.org/github/crypto-com/chain/jobs/706208026#L961

tomtau

``` Compiling mls v0.6.0 (/drone/src/chain-tx-enclave-next/mls) 291 error[E0277]: `?` couldn't convert the error to `keypackage::GenKeyPackageError` 292 --> chain-tx-enclave-next/mls/src/keypackage.rs:309:55 293 | 294 309 | let (_, cert) = parse_x509_der(&certificate.0)?; 295 | ^...

tomtau

Problem: upgrade cmac to 0.5 / crypto-mac to 0.10 fails

1

likely need to be upgraded together

tomtau

will probably need updating hpke etc.

tomtau

ed25519-dalek can be used directly

tomtau

Problem: consensus parameters not checked

2

https://github.com/crypto-com/chain/blob/master/chain-abci/src/app/app_init.rs#L177 note that the comment above it may not longer be relevant (e.g. unbonding time is by default evidence age with the new Tendermint version) -- things to check would...

tomtau

blocked by https://github.com/crypto-com/chain/issues/2182 probably only relevant to multi-node tests -- when another node starts up, it can be provided RPC of the other node and pre-fetch the sealed transactions

tomtau

currently the code bundles it together in `temp_start_up_ra_tx_query` https://github.com/crypto-com/chain/blob/master/chain-abci/src/enclave_bridge/edp/mod.rs#L200 but one may want to start up `SpRaServer` before that (for TDBE/TVE)

tomtau

instead of current two threads ("chain-abci" and "persistence"), it could just be one. instead of taking `Storage`, it'd take some subset (some new definition) that can do the lookups (like...

tomtau