leapchat icon indicating copy to clipboard operation
leapchat copied to clipboard

Published 20 hours ago • verified publisher icon cryptag

Convert codebase: CSS => flexbox

Open elimisteve opened this issue 7 years ago • 4 comments

Then we can reuse all of that work from within React Native, unlike now; React Native doesn't use CSS and has no DOM.

elimisteve avatar May 03 '17 02:05 elimisteve

We might want to discuss, but making a note here: we should convert to flexbox for the May 18th deadline, but for expediency and scope management, maybe skip worrying about style objects for time being. Depends on mobile app timeline.

In any case, I'd suggest this be two separate steps.

jimmcgaw avatar May 12 '17 03:05 jimmcgaw

@jimmcgaw The current layout is working well, and the timeline on native apps is not immediate, so how about we skip the flexbox conversion till after May 18th?

elimisteve avatar May 12 '17 03:05 elimisteve

Split this issue up into 2 as you suggested; Style object issue is now https://github.com/cryptag/leapchat/issues/78

elimisteve avatar May 12 '17 03:05 elimisteve

Much of converting overall layout to flexbox has been addressed here: https://github.com/cryptag/leapchat/pull/85/commits/024b7d7037746dd83414a9f3d74485b58c88d8d0

jimmcgaw avatar May 14 '17 18:05 jimmcgaw