cryostat-operator icon indicating copy to clipboard operation
cryostat-operator copied to clipboard

feat(deployment): core resource requests split with sidecar

Open andrewazores opened this issue 1 year ago • 1 comments

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • [x] Read the contributing guidelines
  • [x] Linked a relevant issue which this PR resolves
  • [x] Linked any other relevant issues, PR's, or documentation, if any
  • [x] Resolved all conflicts, if any
  • [x] Rebased your branch PR on top of the latest upstream main branch
  • [x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • [x] Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Based on #617

Description of the change:

If there is no configuration for -reports sidecar(s), increase the resources requested for the main cryostat container instead.

Motivation for the change:

If the CR does not have any report generation configuration then the Cryostat server will fall back to generating reports itself by forking a subprocess within its container. This at least needs some memory allocation of its own and preferably some CPU time as well to complete its work in a reasonable time. So, in deployments like this, assign the maximum of the CPU and Memory requests that would go to either the core container or the reports container(s) to the core container so that the additional headroom may be used for subprocess report generation.

andrewazores avatar Sep 12 '23 14:09 andrewazores

This PR/issue depends on:

  • ~~cryostatio/cryostat-operator#617~~ By Dependent Issues (🤖). Happy coding!

github-actions[bot] avatar Sep 16 '23 01:09 github-actions[bot]