cryostat-legacy icon indicating copy to clipboard operation
cryostat-legacy copied to clipboard

[Story] cryostat repo integration test suite port

Open maxcao13 opened this issue 2 years ago • 1 comments

There are some integration tests that have been ported directly from the cryostat repo, but are disabled that need fixing. There are some that also haven't been ported over. Here's a current status of all of them.

Emoji Name Status Fixed in PR
ApiListingIT.java passes -
- ArchivedRecordingJwtDownloadIT.java not ported
- ArchivedReportJwtDownloadIT.java not ported
- AutoRulesCleanupIT.java not ported
- AutoRulesIT.java not ported
ClientAssetsIT.java passes
- CredentialsIT.java not ported
- CredentialsV2_2IT.java not ported
CryostatTemplateIT.java passes
CustomTargetsIT.java broken
- DiscoveryIT.java not ported
DiscoveryPluginIT.java broken
- FileSystemArchivedRequestsIT.java not ported
GrafanaSetupIT.java broken
- GraphQLIT.java not ported
HealthIT.java passes ?
InterleavedExternalTargetRequestsIT.java not ported
- JmxAuthIT.java not ported
- JvmIdIT.java not ported
MessagingServerIT.java broken
NonExistentTargetIT.java passes #160
NoopAuthIT.java broken
NoopAuthV2IT.java ported #160
NotificationsUrlIT.java ported #160
- RecordingJwtDownloadIT.java not ported
- RecordingMetadataIT.java not ported
RecordingWorkflowIT.java ported #160
ReportIT.java broken
- ReportJwtDownloadIT.java not ported
RulesPostFormIT.java passes #34
RulesPostJsonIT.java passes #34
- RulesPostMultipartIT.java not ported
SnapshotIT.java ported #178
TargetEventsGetIT.java passes ?
TargetPostDeleteIT.java broken
TargetRecordingOptionsIT.java broken
TargetRecordingPatchIT.java ported https://github.com/cryostatio/cryostat3/pull/183
TargetRecordingsClientErrorIT.java broken
TargetReportIT.java broken
- TemplateJwtDownloadIT.java not ported
TemplatePostDeleteIT.java broken
UploadCertificateIT.java broken
UploadRecordingIT.java ported #150
- WrongServiceListeningOnPortIT.java not ported

maxcao13 avatar Jul 31 '23 17:07 maxcao13

Would this affect command channel connections at all? I'm about to start work on sending commands to container-jfr from the container-jfr-operator.

ebaron avatar Oct 09 '19 20:10 ebaron

@ebaron As far as I know, the command channel is managed by a different web service running on a different port. Also, the command channel uses Websocket, which I believe is not bound by CORS policies.

tabjy avatar Oct 09 '19 20:10 tabjy

The headers are also typically enforced by the end user's browser, not the server, so connections from a "headless" client like the operator would be unaffected anyway. But yea, good question.

andrewazores avatar Oct 09 '19 20:10 andrewazores