cryostat-legacy icon indicating copy to clipboard operation
cryostat-legacy copied to clipboard

[Task] Use `shellcheck` to analyze bundled scripts

Open andrewazores opened this issue 2 years ago • 0 comments

There are currently two shell scripts included in the Cryostat image:

  • https://github.com/cryostatio/cryostat/blob/main/src/main/extras/app/entrypoint.sh
  • https://github.com/cryostatio/cryostat/blob/main/src/container/include/truststore-setup.sh

These should have shellcheck (or some equivalent linting tool) applied to them as part of the build process, the same way we use spotless and spotbugs on the Java sources.

There are other shell scripts around for development use like run.sh/smoketest.sh, devserver.sh, generate-dev-certs.sh, and the repeated-*-tests.bash which would also benefit from this.

Bonus chore: update or just remove build-images.sh.

andrewazores avatar Aug 10 '22 19:08 andrewazores