crunchy-cli icon indicating copy to clipboard operation
crunchy-cli copied to clipboard

Crashing when archiving shows with duplicate subtitles

Open Niklashere opened this issue 3 months ago • 4 comments

Describe the bug If archiving a show that contains the same subtitles with the same name multiple times, the download crashes. This issue has been persistent since version 3.6.0 and upwards. Version 3.5.2 is the last version without the issue.

Example with https://www.crunchyroll.com/de/watch/GRQW94KQR/the-lost-turnabout Downloading subtitles en-US (CC) [Video: #2], en-US (CC) [Video: #2]

Example with https://www.crunchyroll.com/de/watch/GYE5MWEQR/resolve: Downloading subtitles de-DE, en-US, en-US (CC), en-US (CC), es-419, fr-FR, it-IT, pt-BR, ru-RU

To Reproduce

$ crunchy-cli archive --credentials "XYZ:XYZ" -o "test.mkv" https://www.crunchyroll.com/de/watch/GRQW94KQR/the-lost-turnabout

Expected behavior It should download one of the subtitles if video tracks get merged or both subtitles for each video track if no merge is happening.

Screenshots Screenshot 2024-05-07 182434

Client (please complete the following information):

  • OS: Windows 11 Pro (23H2)
  • Version: 3.6.1 (can also be found under 3.6.0)

Additional context tested with: https://www.crunchyroll.com/de/watch/GRQW94KQR/the-lost-turnabout

episodes with similiar isssues: https://www.crunchyroll.com/de/watch/GK9U3JMM8/soccers-zero https://www.crunchyroll.com/de/watch/GYE5MWEQR/resolve https://www.crunchyroll.com/de/watch/GRK537586/cognitive-impairment-is-your-intelligence-okay

Niklashere avatar May 07 '24 16:05 Niklashere