helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Add probes for agent

Open sipr-invivo opened this issue 1 year ago • 2 comments

Fixes #158

Adds the possibility to have probes for the agent statefulset, configurable in the values.yml file (to allow users to use tcp probes for instance)

Tested locally, works as expected

sipr-invivo avatar May 23 '24 13:05 sipr-invivo

@sipr-invivo: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

github-actions[bot] avatar May 23 '24 13:05 github-actions[bot]

@sipr-invivo: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

github-actions[bot] avatar May 23 '24 13:05 github-actions[bot]

/kind enhancement /area configuration

LaurenceJJones avatar Jun 14 '24 10:06 LaurenceJJones

Thanks!

I suggest some changes in my commit

  • raise the probe timeout to 5 seconds in case of load spike
  • enable probes only if metrics are enabled too
  • enable metrics by default

mmetc avatar Jun 25 '24 13:06 mmetc