helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Add duration and renewBefore values for cert-manager certificates

Open erwanval opened this issue 1 year ago • 3 comments

Add options to configure duration and renewBefore fields for Certificates resources. Default values are set to cert-manager's default, duration = 90d, and renewBefore = 30d.

erwanval avatar May 20 '24 15:05 erwanval

@erwanval: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

github-actions[bot] avatar May 20 '24 15:05 github-actions[bot]

@erwanval: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

github-actions[bot] avatar May 20 '24 15:05 github-actions[bot]

/kind enhancement /area configuration

LaurenceJJones avatar May 20 '24 16:05 LaurenceJJones

lgtm but we should add them to README.md

mmetc avatar May 24 '24 07:05 mmetc

Hi @mmetc

The readme is updated through a Github action on merge, no? Or has it changed? I can add them manually otherwise

erwanval avatar May 24 '24 12:05 erwanval

Hi @mmetc

The readme is updated through a Github action on merge, no? Or has it changed? I can add them manually otherwise

Oh sure, I forgot it runs on the push to master, not on the PR. Thanks

mmetc avatar May 24 '24 13:05 mmetc