crowdsec icon indicating copy to clipboard operation
crowdsec copied to clipboard

refact whitelist/allowlist: net.IP to net/netip

Open mmetc opened this issue 6 months ago • 2 comments

since address parsing is stricter we need to log or error depending on context, I'm leaving XXX

mmetc avatar Jun 12 '25 11:06 mmetc

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Jun 12 '25 11:06 github-actions[bot]

Codecov Report

:x: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.63%. Comparing base (2c31290) to head (c18d7fd). :warning: Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apic.go 70.00% 2 Missing and 1 partial :warning:
pkg/parser/whitelist.go 70.00% 2 Missing and 1 partial :warning:
pkg/database/allowlists.go 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3683   +/-   ##
=======================================
  Coverage   60.62%   60.63%           
=======================================
  Files         390      390           
  Lines       41860    41872   +12     
=======================================
+ Hits        25379    25389   +10     
- Misses      14387    14388    +1     
- Partials     2094     2095    +1     
Flag Coverage Δ
bats 44.79% <36.17%> (-0.01%) :arrow_down:
unit-linux 34.13% <78.72%> (+0.01%) :arrow_up:
unit-windows 24.19% <68.08%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 12 '25 12:06 codecov[bot]