crowdsec icon indicating copy to clipboard operation
crowdsec copied to clipboard

refact slicetools.Chunks() -> slices.Chunk()

Open mmetc opened this issue 7 months ago • 3 comments

mmetc avatar May 27 '25 07:05 mmetc

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar May 27 '25 07:05 github-actions[bot]

Codecov Report

:x: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.67%. Comparing base (95a8b47) to head (ef4e50a). :warning: Report is 113 commits behind head on master.

Files with missing lines Patch % Lines
pkg/database/alerts.go 71.42% 2 Missing :warning:
pkg/database/decisions.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3650   +/-   ##
=======================================
  Coverage   60.67%   60.67%           
=======================================
  Files         374      374           
  Lines       41318    41307   -11     
=======================================
- Hits        25069    25065    -4     
+ Misses      14176    14171    -5     
+ Partials     2073     2071    -2     
Flag Coverage Δ
bats 44.75% <60.00%> (-0.02%) :arrow_down:
unit-linux 34.26% <60.00%> (+0.03%) :arrow_up:
unit-windows 24.31% <10.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 27 '25 07:05 codecov[bot]

the standard library panics if the chunk size is 0, even with an empty slice. so using this PR requires adding at least an in/else to each call because we can't use cmp.Or(size, len(slice))

mmetc avatar May 27 '25 10:05 mmetc