pkg/database: replace parameter with explicit methods

[mmetc]

In addition to the method split, I propose to replace the term "soft delete" with "expired". Ideally imho it would be expire/remove instead of soft/hard delete, but it may clash with apiserver or ent generated code.

The decisionID() function can be made generic if needed.

[github-actions[bot]]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 36.04651% with 55 lines in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (fba4237) to head (9c56779).

Files	Patch %	Lines
pkg/database/decisions.go	40.00%	38 Missing and 1 partial :warning:
pkg/apiserver/papi_cmd.go	0.00%	13 Missing :warning:
pkg/apiserver/apic.go	50.00%	2 Missing :warning:
pkg/database/alerts.go	50.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage   52.40%   52.37%   -0.03%     
==========================================
  Files         280      280              
  Lines       35475    35493      +18     
==========================================
  Hits        18591    18591              
- Misses      15043    15062      +19     
+ Partials     1841     1840       -1     

Flag	Coverage Δ
bats	40.14% <24.63%> (-0.02%)	:arrow_down:
unit-linux	34.80% <28.57%> (ø)
unit-windows	30.92% <34.88%> (-0.04%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.