crowdsec
crowdsec copied to clipboard
crowdsecurity
db: don't set machine heartbeat until first connection
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
/kind feature/kind enhancement/kind refactoring/kind fix/kind chore/kind dependencies
Details
I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
/area agent/area local-api/area cscli/area appsec/area security/area configuration
Details
I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.
Codecov Report
Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 52.57%. Comparing base (
44a2014) to head (9ab5dc0).
| Files | Patch % | Lines |
|---|---|---|
| pkg/database/machines.go | 72.72% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #3019 +/- ##
===========================================
+ Coverage 34.13% 52.57% +18.43%
===========================================
Files 280 281 +1
Lines 35407 35409 +2
===========================================
+ Hits 12087 18617 +6530
+ Misses 22020 14981 -7039
- Partials 1300 1811 +511
| Flag | Coverage Δ | |
|---|---|---|
| bats | 40.30% <75.00%> (?) |
|
| unit-linux | 34.83% <0.00%> (-0.02%) |
:arrow_down: |
| unit-windows | 30.97% <0.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yop 👋🏻 same on the prune, for me I would expect prune to delete anything that I set the time for so even if the last heartbeat is nil it should go from creation time instead which is what you already done I believe. I will test this PR shortly and give comments.
