crowdsec icon indicating copy to clipboard operation
crowdsec copied to clipboard

cscli: avoid global vars

Open mmetc opened this issue 1 year ago • 2 comments

This is required to make it possible to split the package

mmetc avatar Apr 29 '24 14:04 mmetc

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Apr 29 '24 14:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 27.49%. Comparing base (05b5468) to head (830e850).

:exclamation: Current head 830e850 differs from pull request most recent head f060856. Consider uploading reports for the commit f060856 to get more accurate results

Files Patch % Lines
cmd/crowdsec-cli/itemcli.go 0.00% 8 Missing :warning:
cmd/crowdsec-cli/items.go 0.00% 6 Missing :warning:
cmd/crowdsec-cli/item_metrics.go 0.00% 5 Missing :warning:
cmd/crowdsec-cli/hub.go 0.00% 4 Missing :warning:
cmd/crowdsec-cli/item_suggest.go 0.00% 4 Missing :warning:
cmd/crowdsec-cli/hubappsec.go 0.00% 1 Missing :warning:
cmd/crowdsec-cli/support.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2977      +/-   ##
==========================================
- Coverage   27.50%   27.49%   -0.01%     
==========================================
  Files         398      398              
  Lines       58396    58400       +4     
==========================================
- Hits        16060    16057       -3     
- Misses      40387    40395       +8     
+ Partials     1949     1948       -1     
Flag Coverage Δ
unit-linux 35.10% <0.00%> (-0.04%) :arrow_down:
unit-windows 25.55% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 29 '24 14:04 codecov-commenter