crowdsec icon indicating copy to clipboard operation
crowdsec copied to clipboard

feat: collect pprofs on cscli support dump

Open LaurenceJJones opened this issue 1 year ago • 4 comments

Fix #2937

Opening as draft since its not really working, I dont know why 🤷🏻 maybe @mmetc can help

LaurenceJJones avatar Apr 12 '24 15:04 LaurenceJJones

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Apr 12 '24 15:04 github-actions[bot]

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Apr 12 '24 15:04 github-actions[bot]

/kind enhancement /area cscli

LaurenceJJones avatar Apr 12 '24 15:04 LaurenceJJones

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 38.82%. Comparing base (3392e5e) to head (cff732c).

Files Patch % Lines
cmd/crowdsec-cli/support.go 64.51% 10 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2940       +/-   ##
===========================================
+ Coverage   27.61%   38.82%   +11.21%     
===========================================
  Files         398      399        +1     
  Lines       57887    57919       +32     
===========================================
+ Hits        15984    22488     +6504     
+ Misses      39949    32927     -7022     
- Partials     1954     2504      +550     
Flag Coverage Δ
bats 30.08% <83.33%> (?)
unit-linux 35.07% <0.00%> (-0.06%) :arrow_down:
unit-windows 25.64% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 12 '24 15:04 codecov-commenter

Works for me, and it takes a long time to download. I'll add a prompt to ask users if they want to include it (will do the same when I do logs). I won't set a timeout.

mmetc avatar May 03 '24 14:05 mmetc

done in https://github.com/crowdsecurity/crowdsec/pull/2987

mmetc avatar May 07 '24 07:05 mmetc