crowdsec icon indicating copy to clipboard operation
crowdsec copied to clipboard

notify systemd start, stop, reload, watchdog

Open mmetc opened this issue 1 year ago • 4 comments

This removes the debug line "systemd not available" but I verified that the function is called and it's a no-op outside systemd.

TODO: WATCHDOG_USEC, signal READY after reload

mmetc avatar Feb 26 '24 14:02 mmetc

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Feb 26 '24 14:02 github-actions[bot]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Feb 26 '24 14:02 github-actions[bot]

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 57.99%. Comparing base (8e9e091) to head (7097891).

Files Patch % Lines
cmd/crowdsec/serve.go 68.57% 8 Missing and 3 partials :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2862   +/-   ##
=======================================
  Coverage   57.98%   57.99%           
=======================================
  Files         240      240           
  Lines       31040    31059   +19     
=======================================
+ Hits        18000    18014   +14     
- Misses      11411    11415    +4     
- Partials     1629     1630    +1     
Flag Coverage Δ
bats 38.01% <68.57%> (+0.02%) :arrow_up:
unit-linux 52.27% <ø> (+0.01%) :arrow_up:
unit-windows 47.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 14:02 codecov[bot]

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 57.99%. Comparing base (2a7e838) to head (7097891). Report is 36 commits behind head on master.

:exclamation: Current head 7097891 differs from pull request most recent head bcbfb9f. Consider uploading reports for the commit bcbfb9f to get more accurate results

Files Patch % Lines
cmd/crowdsec/serve.go 68.57% 8 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2862      +/-   ##
==========================================
- Coverage   58.10%   57.99%   -0.11%     
==========================================
  Files         243      240       -3     
  Lines       31361    31059     -302     
==========================================
- Hits        18221    18014     -207     
+ Misses      11460    11415      -45     
+ Partials     1680     1630      -50     
Flag Coverage Δ
bats 38.01% <68.57%> (-0.18%) :arrow_down:
unit-linux 52.27% <ø> (+0.15%) :arrow_up:
unit-windows 47.78% <ø> (+0.22%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 22 '24 11:04 codecov-commenter