crowdsec icon indicating copy to clipboard operation
crowdsec copied to clipboard

Progress bar for one shot acquisition (time machine / cold logs)

Open mmetc opened this issue 1 year ago • 3 comments

This also disables prometheus metrics in one shot mode because in most cases the port is already taken by LAPI.

Should work for all datasources, but tested only with files.

Windows should work the same as linux if virtual terminal processing is enabled. If not (win < 10? or it depends on the terminal application?), we should do the same as https://github.com/martinlindhe/color/blob/02ab2eaae10c365c22e6f6f2dac0d9cd496f3016/color_windows.go#L9

I had issues building in windows so would like some testing

mmetc avatar Jan 26 '24 10:01 mmetc

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Jan 26 '24 10:01 github-actions[bot]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Jan 26 '24 10:01 github-actions[bot]

Codecov Report

Attention: Patch coverage is 59.34066% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 57.93%. Comparing base (8e9e091) to head (fc1aa39).

Files Patch % Lines
pkg/acquisition/progressbar.go 16.12% 26 Missing :warning:
pkg/types/logging.go 79.62% 7 Missing and 4 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2789      +/-   ##
==========================================
- Coverage   57.98%   57.93%   -0.06%     
==========================================
  Files         240      242       +2     
  Lines       31040    31082      +42     
==========================================
+ Hits        18000    18008       +8     
- Misses      11411    11441      +30     
- Partials     1629     1633       +4     
Flag Coverage Δ
bats 37.96% <59.34%> (-0.02%) :arrow_down:
unit-linux 52.20% <45.34%> (-0.06%) :arrow_down:
unit-windows 47.70% <6.97%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 26 '24 11:01 codecov[bot]