crowdsec icon indicating copy to clipboard operation
crowdsec copied to clipboard

Add acquis docker start script and add inside readme

Open LaurenceJJones opened this issue 2 years ago • 7 comments

LaurenceJJones avatar Aug 12 '23 15:08 LaurenceJJones

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Aug 12 '23 15:08 github-actions[bot]

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Aug 12 '23 15:08 github-actions[bot]

/kind enhancement /area agent

I couldn't think fo a better prefix than ACQUIS dont know if they a more specific key we can use

LaurenceJJones avatar Aug 12 '23 15:08 LaurenceJJones

Codecov Report

Merging #2427 (363a329) into master (afeb541) will decrease coverage by 0.02%. Report is 3 commits behind head on master. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
- Coverage   56.13%   56.11%   -0.02%     
==========================================
  Files         187      187              
  Lines       26027    26027              
==========================================
- Hits        14609    14604       -5     
- Misses       9841     9845       +4     
- Partials     1577     1578       +1     
Flag Coverage Δ
bats 37.72% <ø> (-0.04%) :arrow_down:
unit-linux 54.77% <ø> (+0.03%) :arrow_up:
unit-windows 51.35% <ø> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 12 '23 15:08 codecov[bot]

If we do it.. why base64? There is no need to encode a plaintext

mmetc avatar Aug 18 '23 22:08 mmetc

Base64 to improve some consistency between shells and docker compose, for example.

LaurenceJJones avatar Aug 19 '23 11:08 LaurenceJJones

Base64 to improve some consistency between shells and docker compose, for example.

I'm sorry but do you have an example? I don't see how it helps other than obfuscating, shells and yaml handle multiline strings

mmetc avatar Aug 21 '23 07:08 mmetc