wip: track deleted decisions via a chan for sync
Codecov Report
Merging #1715 (e821324) into master (b0f370b) will decrease coverage by
1.70%. The diff coverage is18.21%.
:exclamation: Current head e821324 differs from pull request most recent head 2190849. Consider uploading reports for the commit 2190849 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
- Coverage 58.14% 56.45% -1.70%
==========================================
Files 115 124 +9
Lines 13944 14892 +948
==========================================
+ Hits 8108 8407 +299
- Misses 5034 5633 +599
- Partials 802 852 +50
| Flag | Coverage Δ | |
|---|---|---|
| unit-linux | 56.26% <18.21%> (-1.89%) |
:arrow_down: |
| unit-windows | 52.10% <17.58%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/apiclient/decisions_sync_service.go | 0.00% <0.00%> (ø) |
|
| pkg/apiserver/papi.go | 0.00% <0.00%> (ø) |
|
| pkg/apiserver/papi_cmd.go | 0.00% <0.00%> (ø) |
|
| pkg/fflag/crowdsec.go | 0.00% <0.00%> (ø) |
|
| pkg/longpollclient/client.go | 0.00% <0.00%> (ø) |
|
| pkg/types/constants.go | 0.00% <0.00%> (ø) |
|
| pkg/apiserver/apiserver.go | 33.80% <10.34%> (-4.41%) |
:arrow_down: |
| pkg/csconfig/console.go | 18.33% <14.28%> (-0.54%) |
:arrow_down: |
| pkg/apiserver/controllers/v1/decisions.go | 47.36% <29.41%> (-2.92%) |
:arrow_down: |
| pkg/apiserver/apic.go | 74.12% <64.04%> (-3.32%) |
:arrow_down: |
| ... and 13 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Note:
There is a bug with cscli alerts list :
sudo cscli alerts list --all
No active alerts
While I have at least an alert from CAPI and one from PAPI
- [ ] Do not add papi url by default to online_credentials as it's opt-in
- [x] Console status doesn't display the new flag (decisions receive)
- [ ] Ensure
cscli decisionslist correctly display decisions from PAPI - [ ] Ensure
cscli alerts listcorrectly displays alerts from PAPI
#ok
./cscli -c dev.yaml alerts list --origin console
#not ok
./cscli -c dev.yaml alerts list -a
/kind feature /area local-api