github-action icon indicating copy to clipboard operation
github-action copied to clipboard

delete_crowdin_branch fails if branch name contains a space

Open weakfl opened this issue 2 years ago • 3 comments

Describe the bug

Trying to cleanup orphaned crowdin branches when PRs are merged/closed, but it fails if the branch name contains a space:

STARTING CROWDIN ACTION
REMOVING BRANCH [prefix] feature.foobar
Unmatched argument at index 3: 'feature.foobar'
SYNOPSIS:
crowdin branch delete <name> [CONFIG OPTIONS] [OPTIONS]

[...]

To Reproduce

A workflow like:

      - name: crowdin action
        uses: crowdin/[email protected]
        with:
          upload_sources: false
          create_pull_request: false
          download_translations: false
          push_translations: false
          delete_crowdin_branch: "[prefix] foobar"

Expected behavior

Delete the crowdin branch.

weakfl avatar Jun 29 '22 16:06 weakfl

@weakfl thanks for the report, already looking into that.

DimaYashchyshyn-zz avatar Jun 29 '22 16:06 DimaYashchyshyn-zz

@DimaYashchyshyn any update regarding this issue?

weakfl avatar Aug 18 '22 08:08 weakfl

@weakfl we're still reviewing this

DimaYashchyshyn-zz avatar Aug 18 '22 21:08 DimaYashchyshyn-zz

Thanks @andrii-bodnar, tested and working.

weakfl avatar Oct 17 '22 14:10 weakfl