crowdin-api-client-ruby icon indicating copy to clipboard operation
crowdin-api-client-ruby copied to clipboard

Req params bundle api

Open sabarish98 opened this issue 1 year ago • 2 comments

Changes:

  • Added code to raise error for all the four required parameters - name format sourcePatterns exportPattern

Please let me know if we need tests for these. I wasn't able to find tests for error flow paths, so didn't add them

sabarish98 avatar Oct 25 '22 19:10 sabarish98

@sabarish98 some checks have failed, please take a look

andrii-bodnar avatar Oct 25 '22 20:10 andrii-bodnar

Codecov Report

Merging #27 (6bffd8b) into main (24ab6c5) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   97.79%   97.79%   +0.01%     
==========================================
  Files          57       57              
  Lines        2484     2486       +2     
==========================================
+ Hits         2429     2431       +2     
  Misses         55       55              
Impacted Files Coverage Δ
lib/crowdin-api/api_resources/bundles.rb 100.00% <100.00%> (ø)
spec/api_resources/bundles_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 25 '22 20:10 codecov[bot]

@andrii-bodnar : Pushed the fix for the case which was failing. The checks should be passing now I hope

sabarish98 avatar Oct 26 '22 04:10 sabarish98

@sabarish98 thanks a lot for your contribution!

andrii-bodnar avatar Oct 26 '22 06:10 andrii-bodnar