crowdin-api-client-java icon indicating copy to clipboard operation
crowdin-api-client-java copied to clipboard

Add more Unit tests for the `reports` package

Open andrii-bodnar opened this issue 1 year ago • 3 comments

The reports package has low code coverage by Unit tests. We need to add more Unit tests to cover the code.

References:

andrii-bodnar avatar Sep 28 '23 12:09 andrii-bodnar

Hey @andrii-bodnar , can I contribute to this ?

chinmaym07 avatar Sep 29 '23 20:09 chinmaym07

@chinmaym07 sure, thank you!

andrii-bodnar avatar Oct 02 '23 09:10 andrii-bodnar

Hi @chinmaym07, any updates on this?

andrii-bodnar avatar Oct 10 '23 07:10 andrii-bodnar

Hi! What is expected code coverage?

DecarteAdam avatar May 03 '24 22:05 DecarteAdam

@DecarteAdam I think that around 80-90% for models would be good

andrii-bodnar avatar May 04 '24 08:05 andrii-bodnar

Hey @andrii-bodnar Can you assign this to me? Thanks

DecarteAdam avatar May 05 '24 21:05 DecarteAdam

Hey @andrii-bodnar Pushed! Can you link this issue to my PR?

DecarteAdam avatar May 06 '24 14:05 DecarteAdam

Hey @DecarteAdam, thank you!

Will review it soon

andrii-bodnar avatar May 06 '24 15:05 andrii-bodnar