crowdin-api-client-java icon indicating copy to clipboard operation
crowdin-api-client-java copied to clipboard

Published 20 hours ago • verified publisher icon crowdin

Add more Unit tests for the `core` package

Open andrii-bodnar opened this issue 1 year ago • 4 comments

The core package has low code coverage by Unit tests. We need to add more Unit tests to cover the code.

References:

andrii-bodnar avatar Sep 28 '23 12:09 andrii-bodnar

Hey @andrii-bodnar I can pick this up.

debanjanc01 avatar Oct 03 '23 19:10 debanjanc01

Hi @debanjanc01, any updates on this?

andrii-bodnar avatar Oct 10 '23 07:10 andrii-bodnar

Hey @andrii-bodnar , I'm still working on it, although my speed has been super slow.

debanjanc01 avatar Oct 11 '23 03:10 debanjanc01

Hey @andrii-bodnar I'm unassigning myself in case someone else wants to pick this up. I'm not getting the time lately to polish my changes and push them.

debanjanc01 avatar Oct 17 '23 13:10 debanjanc01

Hi, What is expected code coverage?

DecarteAdam avatar May 03 '24 22:05 DecarteAdam

@DecarteAdam I think that around 80-90% for the core package would be good

andrii-bodnar avatar May 04 '24 08:05 andrii-bodnar

Hi @andrii-bodnar , I've just pushed. Can you assign this to me pls ?

DecarteAdam avatar May 05 '24 21:05 DecarteAdam

Hey @andrii-bodnar can you link this issue to my PR?

DecarteAdam avatar May 06 '24 14:05 DecarteAdam

Hey @DecarteAdam, thank you!

Will review it soon

andrii-bodnar avatar May 06 '24 15:05 andrii-bodnar