android-studio-plugin icon indicating copy to clipboard operation
android-studio-plugin copied to clipboard

Add import options for translations upload

Open jivjen opened this issue 1 year ago • 4 comments

Description:

This PR is to add new import options for the translations upload as described in #78

jivjen avatar Oct 06 '22 12:10 jivjen

@jivjen thanks a lot for your contribution! 🎉

I will pass this PR for a quick test to our QA team and then will come back to you

andrii-bodnar avatar Oct 06 '22 15:10 andrii-bodnar

@jivjen just received the feedback from our QA team.

It works perfectly when specifying these import options in the root of the configuration file.

But there is an issue when specifying import options for the file groups:

files.source=**/values/strings.xml
files.translation=/values-%two_letters_code%/%original_file_name%
files.import-eq-suggestions=true
files.auto-approve-imported=true
files.translate-hidden=true

In this case, import options are not considered and not passing to the API.

andrii-bodnar avatar Oct 14 '22 13:10 andrii-bodnar

@jivjen probably, here we need an additional check for the import options presence in the FileBean fileBean object

The fileBean (file group) import options should have a higher priority than the root config import options

andrii-bodnar avatar Oct 17 '22 15:10 andrii-bodnar

Hi @jivjen, do you need any assistance with this?

andrii-bodnar avatar Oct 20 '22 15:10 andrii-bodnar