Firebot icon indicating copy to clipboard operation
Firebot copied to clipboard

New Profile Angular Errors

Open phroggster opened this issue 8 months ago • 0 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

Current Behavior

Angular errors are generated several times per second in a new Firebot profile after an event gets triggered to display in the activity feed.

This appears to be related to the default setting value for DashboardLayout returning an empty object ({}) after the settings bump, while chatMessagesController only checks if it's nullish before overriding it, which will never succeed.

It can be worked around by resizing the activity feed panel, such that the user's settings get serialized with the panel sizing included.

Expected Behavior

Less-spammy renderer logs.

Steps To Reproduce

  1. Create a new Firebot profile.
  2. Get any event to display in the Activity Feed.

Version

v5.64.0

What operating system are you using Firebot on?

Windows 10

Relevant log output

[2025-04-08 14:31:14.0758] - error: [v5.64.0] (Renderer) TypeError: Cannot read properties of undefined (reading 'replace')
    at $scope.hideEventLabel (file:///F:/src/firebot/build/gui/app/controllers/chat-messages.controller.js:17:85)
    at fn (eval at compile (F:\src\firebot\node_modules\angular\angular.js:16548:15), <anonymous>:4:162)
    at Scope.$digest (F:\src\firebot\node_modules\angular\angular.js:19262:34)
    at Scope.$apply (F:\src\firebot\node_modules\angular\angular.js:19630:24)
    at tick (F:\src\firebot\node_modules\angular\angular.js:14397:38)
[2025-04-08 14:31:14.0759] - error: [v5.64.0] (Renderer) TypeError: Cannot read properties of undefined (reading 'replace')
    at $scope.hideEventLabel (file:///F:/src/firebot/build/gui/app/controllers/chat-messages.controller.js:17:85)
    at fn (eval at compile (F:\src\firebot\node_modules\angular\angular.js:16548:15), <anonymous>:4:162)
    at Scope.$digest (F:\src\firebot\node_modules\angular\angular.js:19262:34)
    at Scope.$apply (F:\src\firebot\node_modules\angular\angular.js:19630:24)
    at tick (F:\src\firebot\node_modules\angular\angular.js:14397:38)
[2025-04-08 14:31:14.0761] - error: [v5.64.0] (Renderer) TypeError: Cannot read properties of undefined (reading 'replace')
    at $scope.hideEventLabel (file:///F:/src/firebot/build/gui/app/controllers/chat-messages.controller.js:17:85)
    at fn (eval at compile (F:\src\firebot\node_modules\angular\angular.js:16548:15), <anonymous>:4:162)
    at Scope.$digest (F:\src\firebot\node_modules\angular\angular.js:19262:34)
    at Scope.$apply (F:\src\firebot\node_modules\angular\angular.js:19630:24)
    at tick (F:\src\firebot\node_modules\angular\angular.js:14397:38)

Repeated hundreds to thousands of times per-second...

Contact Details (Optional)

No response

phroggster avatar Apr 08 '25 15:04 phroggster