Firebot icon indicating copy to clipboard operation
Firebot copied to clipboard

[Bug] Update Channel Rewards based Sort Tags not working

Open arblane opened this issue 1 year ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

Updating the Channel Reward Pause state is not peforming as expected.

Expected Behavior

Channel Rewards with tag 'SFX' should be updated with the set value of Pause/UnPaused.

Steps To Reproduce

  1. Create or use existing Channel Reward (Firebot created).
  2. Add a tag, 'SFX' for example.
  3. Create Preset Effect List that Updates Channel Reward by Sort Tag ('SFX') and Update Paused value is set to 'Pause'.
  4. Save and Test Preset Effect List

Version

5.63.2 and firebot-v5.63.2-nightly.24.10.03

What operating system are you using Firebot on?

Windows 11

Relevant log output

[2024-10-16 18:23:47.0036] - info: [v5.63.2] DBG: [Oct 16th 2024 2:23 pm] Toggle CPR - Disabled
[2024-10-16 18:23:47.0040] - error: [v5.63.2] Unhandled promise rejection 
{
  message: "Cannot read properties of undefined (reading 'includes')",
  stack: "TypeError: Cannot read properties of undefined (reading 'includes')\n" +
    '    at C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\effects\\builtin\\update-channel-reward.js:271:47\n' +
    '    at Array.filter (<anonymous>)\n' +
    '    at Object.onTriggerEvent (C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\effects\\builtin\\update-channel-reward.js:271:14)\n' +
    '    at C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:89:40\n' +
    '    at new Promise (<anonymous>)\n' +
    '    at triggerEffect (C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:68:12)\n' +
    '    at C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:147:40'
}

Contact Details (Optional)

arblane

arblane avatar Oct 16 '24 18:10 arblane

The same behavior appears to be occurring for Disable/Enable updates.

arblane avatar Oct 16 '24 18:10 arblane

image

arblane avatar Oct 16 '24 18:10 arblane

Who Owns SFX?

CKY- avatar Oct 16 '24 18:10 CKY-

image

arblane avatar Oct 16 '24 18:10 arblane

Changed Hydrate and Posture Check tags from 'SFX' to 'CPR' for testing, to avoid collision with unmanaged shared tag with Quack. Same result of not updating Channel Reward and logged unhandled promise rejection.

arblane avatar Oct 16 '24 18:10 arblane