Firebot icon indicating copy to clipboard operation
Firebot copied to clipboard

Theme support for background color on more elements

Open fluxstorm0 opened this issue 1 year ago • 4 comments

Description of the Change

Effect list options and chat alerts were not displaying the proper colors based on selected color scheme. Slightly expanded support of the theme system to support background colors for chat alerts and effect list items.

Applicable Issues

N/A

Testing

Manual testing by choosing each theme to verify the modified elements are properly displayed.

Screenshots

image image

fluxstorm0 avatar Sep 16 '24 19:09 fluxstorm0

Target branch should be v5, not master :P

Oceanity avatar Sep 16 '24 20:09 Oceanity

Target branch should be v5, not master :P

👍 - I also found another background to fix so I will close this and reopen targeting v5 and with the new fix.

Thanks!

VisitingOcean avatar Sep 16 '24 22:09 VisitingOcean

Target branch should be v5, not master :P

👍 - I also found another background to fix so I will close this and reopen targeting v5 and with the new fix.

Thanks!

You don't have to close it, you can edit the target branch, and you can push commits to this without making a new one, better practice to keep the conversations around!

Oceanity avatar Sep 16 '24 23:09 Oceanity

Just to show how to do it 😛

https://github.com/user-attachments/assets/97b5d8fd-3479-45db-b342-b6425d0d0dcb

Oceanity avatar Sep 17 '24 14:09 Oceanity

I think the removal of the effect chooser modal element borders was perhaps in err? The flat look of the list now is jarring. css issue

Though, the readability improvement under light theme is drastic! light theme

phroggster avatar Oct 21 '24 21:10 phroggster