Firebot icon indicating copy to clipboard operation
Firebot copied to clipboard

Mark user active on channel point redemption

Open codehdn opened this issue 1 year ago • 0 comments

Description of the Change

Marks a user active on channel point redemption. Updates RewardRedemptionMetadata type to include userId and userDisplayName, these then get checked on the triggerChannelReward method to make sure theyre truthy, if theyre not it is assumed the streamer triggered the use of the channel reward and as such doesnt mark the user active.

Applicable Issues

#2537

Testing

  • I dont have a affiliate twitch account at this time so I have not personally tested this change

  • For testing I would setup a channel reward

  • have a user join chat and wait for it to become inactive

  • have that same user redeem a channel reward and verify they become active

  • also need to test for when a user is not in the chat user list yet (CKY mentioned possible weirdness here)

  • Need to test what happens when the redemption gets put into an effect queue, does it still mark user active or does it assume the streamer sent it in

Per CKY testing in the discord:

" this change is working as advertised. there was a flutter when a user who was not in the list appeared after using a redeem i would say PR it and let the core team have a look"

  • https://discord.com/channels/372817064034959370/372822810168393728/1235656878990823517

Screenshots

None

codehdn avatar May 02 '24 18:05 codehdn