Firebot icon indicating copy to clipboard operation
Firebot copied to clipboard

[Bug] Update Currency-Target-Online Users in Role

Open Badhabits opened this issue 2 years ago • 0 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

When you Update Currency to Users in Online Role it does not work. What is worse is that if you have an event with an Update Currency in Online Role that has an Effect Queue it will permanently break the Effect Queue not allowing anything else in the Effect Queue to start until FireBot is restarted. Also I get an error in the logs posted below.

Thanks for always being on top of things, your work is always highly appreciated, means so much to so many people and you do not get even 1% of the recognition you all deserve in my book.

Much Respect -Badhabitz

Expected Behavior

When you use Update Currency to Users in Online Role it properly adds/removes/sets the currency specified.

Also that when you use Update Currency to Users in Online Role it does not break the Effect Queue and doesn't allow anything else to start until you restart Firebot.

Steps To Reproduce

  1. Create Event (On Follow)
  2. Create Effect Update Currency
  3. Target- Online Users in Role
  4. Choose Active Chat User
  5. Amount 100
  6. Message to Send Hi $randomNumber[1, 5000] (This way its not a dupe message and sends)
  7. Add to a newly created Sequential Queue
  8. Test it
  9. Test it again

The Event will run any other effects before the Update Currency Event Once and anything else in that queue will not work till you restart firebot

Version

v5.53.2

What operating system are you using Firebot on?

Windows 10

Relevant log output

15:36:21 GMT-0500 (Central Daylight Time) - error: [v5.53.2] Unhandled promise rejection 
{
  message: 'u.twitchRoles.map is not a function or its return value is not iterable',
  stack: 'TypeError: u.twitchRoles.map is not a function or its return value is not iterable\n' +
    '    at C:\\Users\\Profile\\AppData\\Local\\firebotv5\\app-5.53.2\\resources\\app.asar\\backend\\database\\currencyDatabase.js:181:38\n' +
    '    at Array.map (<anonymous>)\n' +
    '    at C:\\Users\\Profile\\AppData\\Local\\firebotv5\\app-5.53.2\\resources\\app.asar\\backend\\database\\currencyDatabase.js:179:14'
}

Contact Details (Optional)

Badhabitz#8988

Badhabits avatar Jul 26 '22 21:07 Badhabits